feat(github): show a single multi-env plan change inline#680
Merged
Conversation
Only collapse a multi-environment plan section's DDL behind a details block when it has more than one change. A single statement (or a lone VSchema diff) is small enough to read without a click, so render it inline while keeping the summary below.
There was a problem hiding this comment.
Pull request overview
This PR improves the UX of multi-environment plan comments by rendering per-environment plan output inline when there is exactly one total change (DDL statements + VSchema diffs), and only collapsing the “detailed changes” section behind a <details> block when there is more than one change.
Changes:
- Update multi-env per-environment rendering to inline a single change and collapse only when
totalChanges > 1. - Add/adjust tests to cover the new “single change inline” behavior while preserving collapse behavior and singular/plural summary text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/webhook/templates/plan.go | Inline-render single-change environment sections; keep <details> collapse for multi-change sections. |
| pkg/webhook/plan_test.go | Add a new test for single-change inline rendering; keep coverage for collapse summary wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
aparajon
approved these changes
Jul 6, 2026
Kiran01bm
added a commit
that referenced
this pull request
Jul 6, 2026
…ew-drift-rollup * origin/main: feat(github): show a single multi-env plan change inline (#680) fix(github): parse any configured environment in -e flag (#679) chore(deps): bump block/vitess for mysqltopo notification refcount fix (#678) feat(github): summarize unsafe changes with a count (#674) feat(github): collapse multi-env plan DDL behind a details block (#673) fix(tern): fail closed on drives outside the client's database scope (#672) fix(serve): stop the operator before closing the gRPC client (#676) fix(tern): notify late-registered observers of settled applies (#675) chore(deps): bump block/vitess to release-24.0 head (mysqltopo fixes) (#655) docs(agents): forbid rendering untrusted error strings in PR markdown (#671) docs(agents): assert Close only on a handle's sole owner (#670) feat(api): verify the reviewed plan's origin deployment at rollup time (#669) fix(github): acknowledge a command only when a deployment acts on it (#664) fix(github): leader re-folds on its own schedule when participants have not reported (#668) test(github): cover the review-time deployment drift gate end to end (#667) fix(github): reject contradictory revert and skip-revert commands (#637) fix(tern): queue dispatched applies for the operator drive (#635) feat(github): list authorized teams and users on command rejection (#665) # Conflicts: # pkg/webhook/plan.go # pkg/webhook/plan_drift.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-environment plan comments collapse each environment's DDL behind a
<details>block so a large plan doesn't dominate the comment. For a planwith just one change that collapse adds a needless click. This renders a
single change inline and only collapses when there is more than one.
The threshold is the total change count (DDL statements + VSchema diffs),
so a lone VSchema change is also shown inline, not just a lone SQL
statement. Single-environment plans already rendered inline; this only
affects the per-environment sections of a multi-env comment.
Behavior